Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow "-" or "." #309

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Do not allow "-" or "." #309

merged 2 commits into from
Apr 2, 2024
+1 −1

Conversation

Innders
Copy link
Member

@Innders Innders commented Mar 29, 2024 •
edited

Changelog Description

  • Do not allow - or . in entity names.
  • Only allowed characters are letters (uppercase and lowercase) and underscores _.
  • Any invalid character/space will replaced with an _

Additional Information

✅ folder_1
❌ folder 1, folder-1, folder.1, folder@1 ➡️ folder_1

@BigRoy
Copy link
Contributor

BigRoy commented Mar 29, 2024

Did you intend to also disallow numbers?

BigRoy
BigRoy reviewed Mar 29, 2024
View reviewed changes
src/helpers/checkName.js Outdated Show resolved Hide resolved
@Innders @BigRoy
fix regex
1cc580e 
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@Innders Innders removed the request for review from iLLiCiTiT April 2, 2024 11:11
@Innders Innders merged commit d132465 into develop Apr 2, 2024
@Innders Innders deleted the fix/entity-name-do-not-allow-hyphen-or-period branch April 2, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy left review comments

@martastain martastain martastain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Innders @BigRoy @martastain